Attention is currently required from: laforge, pespin.
View Change
1 comment:
Commit Message:
Patch Set #3, Line 12: Use OTC_SELECT
Agree with Harald.
Sorry, I disagree with what you are doing here.
You are asking me to clutter log printing with premature optimisations.
There will be absolutely no visible effect at all.
I'm very puzzled why you guys don't see that.
We are stalling an entire feature branch on a microscopic bikeshed.
To view, visit change 33169. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Id903b8579ded8b908e644808e440d373bcca8da4
Gerrit-Change-Number: 33169
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Jun 2023 12:19:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de>
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment