Attention is currently required from: iedemam, neels, pespin, fixeria, dexter.

View Change

2 comments:

• File include/osmocom/bsc/bts.h:

  • Patch Set #4, Line 524: chan_alloc_allow_tch_for_signalling

    cosmetic: I'd rename it to "tch_for_signalling_policy" or something like that which makes it more clear that it's no longer some boolean value. Changing from bool to an enum but keeping the name identical might also hide bugs, as existing code using "if (chan_alloc_allow_tch_for_signalling)" will still compile but probably no longer do what we expect it to do.

• File src/osmo-bsc/bts_vty.c:

  • Patch Set #4, Line 568: DEFUN_ATTR

    it might be nice to add a backwards-compatibility alias for the (0|1) so old config files still parse.

To view, visit change 28276. To unsubscribe, or for help writing mail filters, visit settings.