Attention is currently required from: Hoernchen, fixeria.
8 comments:
File Transceiver52M/Makefile.am:
Patch Set #11, Line 88: grgsm_vitac/grgsm_vitac.cpp \
is this only to be used in ms-trx? why not moving it to subdir ms/grgsm_vita/ then?
Patch Set #11, Line 179: osmo_trx_syncthing_blade_CPPFLAGS = $(AM_CPPFLAGS) $(BLADE_CFLAGS) -DSYNCTHINGONLY -DBUILDBLADE -I../device/ipc
$(top_srcdir)/Transceiver52/device/ipc? not sure if it's a good idea to use relative paths there.
File Transceiver52M/ms/itrq.h:
Patch Set #11, Line 127: class spsc : public T<block_read, block_write> {
didn't we have an implementation of this somewhere else already?
File Transceiver52M/ms/logging.cpp:
Patch Set #11, Line 83: void trxc_log_init(void *tallctx)
shouldn't this be called "trxcon_log_init"?
File Transceiver52M/ms/ms.cpp:
Patch Set #11, Line 312: // in thory fn equal and tn+3 equal is also a problem...
theory
File Transceiver52M/ms/ms_upper.cpp:
Patch Set #11, Line 297: case trxcon::TRXCON_PHYIF_CMDT_RESET:
value_string?
File Transceiver52M/ms/sch.h:
Patch Set #11, Line 7: * (C) 2022 by 2022 by sysmocom s.f.m.c. GmbH <info@sysmocom.de> / Eric Wild <ewild@sysmocom.de>
repeated "2022 by"
File Transceiver52M/ms/sch.c:
Patch Set #11, Line 97: int gsm_fcch_check_fn(int fn)
don't we have these sort of functionalities already in libosmocore?
To view, visit change 30416. To unsubscribe, or for help writing mail filters, visit settings.