pespin has uploaded this change for review.

View Change

sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason

Until recently, libosmo-sigtran was incorrectly expecting low-level
wire-format cause in N-DISCONNECT.req. Nowadays it supports specific
reason values in the SCCP-User SAP, so use those instead.

Related: OS#2601
Change-Id: I17bceb7dbd6d8198a07c232eee8aebb7b89a3bf2
---
M TODO-RELEASE
M src/osmo-bsc/osmo_bsc_sigtran.c
2 files changed, 5 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/43799/1
diff --git a/TODO-RELEASE b/TODO-RELEASE
index 0ed7189..b6d61b1 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,3 +7,4 @@
# If any interfaces have been added since the last public release: c:r:a + 1.
# If any interfaces have been removed or changed since the last public release: c:r:0.
#library what description / commit summary line
+libosmo-sigtran >2.3.0 OSMO_SCCP_REL_REASON_NSU_*
diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c
index 1fe7739..c96aebf 100644
--- a/src/osmo-bsc/osmo_bsc_sigtran.c
+++ b/src/osmo-bsc/osmo_bsc_sigtran.c
@@ -234,7 +234,10 @@

return 0;
refuse:
- osmo_sccp_tx_disconn(scu, scu_prim->u.connect.conn_id, &scu_prim->u.connect.called_addr, 0);
+ osmo_sccp_tx_disconn(scu,
+ scu_prim->u.connect.conn_id,
+ &scu_prim->u.connect.called_addr,
+ OSMO_SCCP_REL_REASON_NSU_CREF_END_USER_ORIGIN);
return rc;
}


To view, visit change 43799. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I17bceb7dbd6d8198a07c232eee8aebb7b89a3bf2
Gerrit-Change-Number: 43799
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>