Attention is currently required from: fixeria.
Patch set 3:Code-Review +1
2 comments:
Patchset:
This is already implemented and working. Here's the firmware boot log for K2xx: […]
Done
File src/target/firmware/board/se_k2xx/rf_tables.c:
Patch Set #2, Line 30: uint8_t apc_offset = 48;
Just to clarify: `APCOFF = 0x07F` is 127 in decimal, but you suggest 63. […]
Your comment in the new patch iteration is fine. For the structure of APCOFF register, see TWL3025_SWRS021.pdf document, section 5.3.6.5 on page 71. The low 6 bits are the APC offset (the number we are after here, and the field after which the register was named), but bit 0x40 is another, mostly unrelated setting. That other bit setting (ramp slope selection) is not factored out per-target in OBB, but it does not need to be: the current setting of 1 is correct for all currently supported targets.
To view, visit change 42604. To unsubscribe, or for help writing mail filters, visit settings.