Attention is currently required from: laforge, fixeria.

View Change

4 comments:

• File src/common/measurement.c:

  • Patch Set #1, Line 23: /* TCH/H(0): 0, 2, 4, 6, 52, 54, 56, 58 */

    Maybe use ";" to separate between the 2 blocks, it's easier to understand:
    /* TCH/H(0): 0, 2, 4, 6; 52, 54, 56, 58 */
    Or is 1 block 8 FNs here?

  • Patch Set #1, Line 26: /* TCH/H(1): 14, 16, 18, 20, 66, 68, 70, 72 */

    same

  • Patch Set #1, Line 65: * There is only one *complete* block in this subset starting at FN=52.

    So you first say there's a complete block starting at FN=52, but in next line you say the one starting at 52 is incomplete?

• File tests/meas/meas_test.c:

  • Patch Set #1, Line 385: if (fn == 0) /* H0 block { 0, 2, 4, 6} */

    As shared in another patch, switch sounds more clean here imho. Not important though.

To view, visit change 28086. To unsubscribe, or for help writing mail filters, visit settings.