Attention is currently required from: jolly, pespin.
View Change
1 comment:
File src/input/misdn.c:
Patch Set #5, Line 110: get_value_string(e1inp_signal_names, S_L_INP_LINE_SA_BITS),
Yes, indeed. I'll indent it to column after "LOGP(".
btw, i usually indent to the opening brace because that's what vim does for me, but also simply indenting by one tab is totally fine and has its own benefits.
To view, visit change 31033. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Id8b6fad9b073cf92eee92a6906bf5b57af37e2f0
Gerrit-Change-Number: 31033
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: neels <nhofmeyr@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Feb 2023 02:29:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas@eversberg.eu>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment