Attention is currently required from: fixeria, jolly.
View Change
1 comment:
Commit Message:
Patch Set #2, Line 19: Rx only mode makes no sense for data calls, so in tch_recv_cb() we
You may have a race condition between dropping rx valid data and signalling data transfer started here? In a voice call you don't care much, but probably in here you drop valid data?
I'm not sure about all this, just sharing in case it makes sense.
To view, visit change 35739. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Idd32c823639cc1f9999d77fcefe7e260e31a85ec
Gerrit-Change-Number: 35739
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: jolly <andreas@eversberg.eu>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Feb 2024 18:09:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment