pespin submitted this change.

View Change

Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified
gsmtap: Increase txqueue max_length from 64 to 1024

The default value may be too low for main loop iterations writing a lot
of output. Increase it to a saner value.

Change-Id: Ie737e1d060ea3ee48631604bbae1b8b84cf787b9
---
M src/core/gsmtap_util.c
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/core/gsmtap_util.c b/src/core/gsmtap_util.c
index b64c7b0..62d3ffa 100644
--- a/src/core/gsmtap_util.c
+++ b/src/core/gsmtap_util.c
@@ -496,8 +496,8 @@
if (osmo_iofd_register(gti->out, gti->wq.bfd.fd) < 0)
goto err_cleanup;

- /* osmo write queue previously used was set up with value of 64 */
- osmo_iofd_set_txqueue_max_length(gti->out, 64);
+ /* Use a big enough tx queue to avoid gsmtap messages being dropped: */
+ osmo_iofd_set_txqueue_max_length(gti->out, 1024);
}

return gti;

To view, visit change 38887. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie737e1d060ea3ee48631604bbae1b8b84cf787b9
Gerrit-Change-Number: 38887
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>