Patch set 2:Code-Review +1
View Change
1 comment:
Commit Message:
Patch Set #1, Line 10: TS-Service Centre Address field. However, even though the encoding
TS 31.102 consistently and repeatedly calls it "TS-Service Centre Address"
3 x times it's TS-Service Centre Address, and 1 x time it's TP-Service Centre Address. Also, in our code the respective field is named `tp_sc_addr` - this is why I got suspicious. TP is Transport Protocol, TS is... I have no idea. Anyways, not a merge blocker.
To view, visit change 42469. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I55c123c9e244e5a6e71a0348f5d476ef03e618e8
Gerrit-Change-Number: 42469
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 19:07:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>