pespin submitted this change.

View Change

Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified
vty: Improve 'show hnb' param input

Make it more logic to what user expects, specially wrt to other existing
commands in the osmocom world.

Change-Id: If329d57f701b0c53a61c89aae8b7ea421f728566
---
M src/osmo-hnbgw/hnbgw_vty.c
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/osmo-hnbgw/hnbgw_vty.c b/src/osmo-hnbgw/hnbgw_vty.c
index 45f3567..e83bfbc 100644
--- a/src/osmo-hnbgw/hnbgw_vty.c
+++ b/src/osmo-hnbgw/hnbgw_vty.c
@@ -219,8 +219,8 @@

#define SHOW_HNB_STR SHOW_STR "Display information about HNB\n"

-DEFUN(show_hnb, show_hnb_cmd, "show hnb all",
- SHOW_HNB_STR "All HNB\n")
+DEFUN(show_hnb, show_hnb_cmd, "show hnb",
+ SHOW_HNB_STR)
{
struct hnb_context *hnb;
unsigned int count = 0;
@@ -240,8 +240,8 @@
return CMD_SUCCESS;
}

-DEFUN(show_one_hnb, show_one_hnb_cmd, "show hnb NAME ",
- SHOW_HNB_STR "HNB name\n")
+DEFUN(show_one_hnb, show_one_hnb_cmd, "show hnb name NAME",
+ SHOW_HNB_STR "HNB name\n" "HNB name\n")
{
struct hnb_context *hnb;
const char *identity_info = argv[0];

To view, visit change 41446. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: If329d57f701b0c53a61c89aae8b7ea421f728566
Gerrit-Change-Number: 41446
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>