Attention is currently required from: pespin.

View Change

2 comments:

• File src/coding/gsm0503_coding.c:

  • Patch Set #1, Line 2685: case AMR_OTHER:

    so no more "AMR_OTHER" case now? It goes into default?

    Yes, it goes to default. As stated in the commit message, we don't split up detection and decoding of SID_UPDATE onto two frames anymore. This is also why I remove 'dtx_prev' above.

• File tests/dtx/dtx_gsm0503_test.ok:

  • Patch Set #1, Line 23: ==> gsm0503_tch_ahs_decode_dtx() yields 'AMR_OTHER (audio)' (rc=-1, BER 111/212)

    Shouldn't this be BER 212/212?

    Not really. gsm0503_tch_ahs_decode_dtx() internally matches deinterleaved bits against several bit-sequences (markers), so in this case some bits matched one of the markers, but only part of it.

To view, visit change 28166. To unsubscribe, or for help writing mail filters, visit settings.