Attention is currently required from: lynxis lazus.

View Change

3 comments:

• File usb/class/dfu/device/dfudf.c:

  • Patch Set #2, Line 246: if (!(usb_dfu_func_desc->bmAttributes & USB_REQ_DFU_DNLOAD)) { // download is not enabled

    Moving this whole block into a function with early returns may make the code a lot easier to follow.

    In that case you can also drop the "else if" and have them as "if".

    Actually, you can already remove the "else if" now and have them as "if" in here?

• File usb_start.c:

  • Patch Set #2, Line 171: /* FIXME: check if dfu_download_offset / length are valid */

    is this related to the changes in this commit?

  • Patch Set #2, Line 178: CRITICAL_SECTION_ENTER();

    why do you need the critical section here exactly? to increment dfu_download_offset?

To view, visit change 42174. To unsubscribe, or for help writing mail filters, visit settings.