Attention is currently required from: Hoernchen, fixeria, laforge, tnt, ttsou.
View Change
2 comments:
Patchset:
Patch Set #1:
You're changing the existing code, which is not properly formatted in the first place. […]
Done
Commit Message:
Patch Set #1, Line 9: The existing code sets the pingOffset variable to -7231(269 - 7500) with tx-sps = 4. The (apparent) correct value for pingOffset for tx/rx-sps 4 is 272.
Please adjust the commit message formatting to avoid very long lines: wrap it to about 72 characters […]
got it, new commit message in patchset 2
To view, visit change 41231. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I3b08c23a3e7d4a226cd23b9fe42558f596a63257
Gerrit-Change-Number: 41231
Gerrit-PatchSet: 2
Gerrit-Owner: tempest <jackleea1b@gmail.com>
Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: tnt <tnt@246tNt.com>
Gerrit-Reviewer: ttsou <tom@tsou.cc>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: Hoernchen <ewild@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: tnt <tnt@246tNt.com>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: ttsou <tom@tsou.cc>
Gerrit-Comment-Date: Wed, 22 Oct 2025 20:38:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tempest <jackleea1b@gmail.com>
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>