View Change

2 comments:

• File gtp/gtp.h:

  • Patch Set #2, Line 106: #define GTPCAUSE_129 129 /* For future use 129-176 */

    You broke the API compat here. […]

    I'm not opposed, but then that would mean removing all eight of these defines:

    ```c
    #define GTPCAUSE_006 6 /* For future use 6-48 */
    #define GTPCAUSE_049 49 /* Cause values reserved for GPRS charging protocol use (See GTP' in GSM 12.15) 49-63 */
    #define GTPCAUSE_064 64 /* For future use 64-127 */
    #define GTPCAUSE_131 131 /* For future use 131-176 */
    #define GTPCAUSE_177 177 /* Cause values reserved for GPRS charging protocol use (See GTP' In GSM 12.15) 177-191 */
    #define GTPCAUSE_198 198 /* For future use */
    #define GTPCAUSE_221 221 /* For Future Use 221-240 */
    #define GTPCAUSE_241 241 /* Cause Values Reserved For Gprs Charging Protocol Use (See Gtp' In Gsm 12.15) 241-255 */
    ```

    Having one value defined for a range is pretty useless anyway.

  • Patch Set #2, Line 142: static inline bool gtp_cause_successful(uint8_t cause)

    not sure this is really useful to have here, I'd would have left it for the specific app. […]

    It's used directly in libgtp as well: https://gerrit.osmocom.org/c/osmo-ggsn/+/35125

To view, visit change 35084. To unsubscribe, or for help writing mail filters, visit settings.