fixeria submitted this change.

View Change

Approvals: Hoernchen: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified
fixup: firmware/layer1: introduce experimental PDCH support

This regression was introduced with the experimental PDCH support
back in 2020. In particular, I made a mistake in the l1s_nb_resp()
resetting rxnb.dl->link_id to 0x00 if MF_F_PTCCH is not set, which
is of course not set for non-PDCH channels.

Change-Id: I8593f9b001e669e7cd10cc42c05221a6037e8ae1
Fixes: 67c49ba664f7d7d7f07986a20e6d6363a27e3fc4
Fixes: OS#5791, OS#5133
---
M src/target/firmware/layer1/prim_rx_nb.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/target/firmware/layer1/prim_rx_nb.c b/src/target/firmware/layer1/prim_rx_nb.c
index 9656cf9..d6dd82a 100644
--- a/src/target/firmware/layer1/prim_rx_nb.c
+++ b/src/target/firmware/layer1/prim_rx_nb.c
@@ -122,7 +122,7 @@
/* Set SACCH indication in Link IDentifier */
if (mf_task_flags & MF_F_SACCH)
rxnb.dl->link_id = 0x40;
- if (mf_task_flags & MF_F_PTCCH)
+ else if (mf_task_flags & MF_F_PTCCH)
rxnb.dl->link_id = 0x80;
else
rxnb.dl->link_id = 0x00;

To view, visit change 30306. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I8593f9b001e669e7cd10cc42c05221a6037e8ae1
Gerrit-Change-Number: 30306
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged