Attention is currently required from: jolly, pespin.

View Change

1 comment:

• File src/core/osmo_io_internal.h:

  • Patch Set #3, Line 140: int msg_max;

    this field should probably be in struct osmo_iofd.

    I agee. The only reason to have it here was in case the value would change during the lifetime of an io_fd. Like if sometimes we wanted 1, sometimes 5 and sometimes 10 msgb per read/write. As we don't want that, it should indeed go to osmo_iofd, of course with a more descriptive name.

To view, visit change 40491. To unsubscribe, or for help writing mail filters, visit settings.