Attention is currently required from: osmith.

Patch set 1:Code-Review +1

View Change

2 comments:

• File src/libmsc/gsm_04_08_cc.c:

  • Patch Set #1, Line 845: TX Setup with assigned transaction. This is not allowed

    I find this message a bit confusing, maybe say "transaction ID is already assigned"?
    Not critical, can be done in a separate patch.

  • Patch Set #1, Line 847:

    		mncc_release_ind(trans->net, trans, trans->callref,
    				 GSM48_CAUSE_LOC_PRN_S_LU,
    				 GSM48_CC_CAUSE_RESOURCE_UNAVAIL);
    		
    

    Maybe keep this in `gsm48_cc_tx_setup()`?

    ```
    rc = gsm48_cc_tx_setup_set_transaction_id(trans);
    if (rc < 0) {
        mncc_release_ind(trans->net, trans, trans->callref,
                         GSM48_CAUSE_LOC_PRN_S_LU,
                         GSM48_CC_CAUSE_RESOURCE_UNAVAIL);
        trans->callref = 0;
        goto error;
    }
    ```

To view, visit change 41038. To unsubscribe, or for help writing mail filters, visit settings.