falconia submitted this change.

View Change



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified
MNCC debug log: fix logged line number for Tx messages

Every time a message is sent from CC to MNCC, internal function
mncc_recvmsg() gets called. It appears the intent was to log the
line number from which it was called, but the code would log the
line number inside mncc_recvmsg() itself. Fix it.

Change-Id: I5c7070fb383a1aa42ab45478076be444d6b211f4
---
M src/libmsc/gsm_04_08_cc.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c
index 11bebb0..9ac018e 100644
--- a/src/libmsc/gsm_04_08_cc.c
+++ b/src/libmsc/gsm_04_08_cc.c
@@ -306,7 +306,7 @@
unsigned char *data;

mncc->msg_type = msg_type;
- log_mncc_rx_tx(trans, "tx", (union mncc_msg *)mncc);
+ _log_mncc_rx_tx(file, line, trans, "tx", (union mncc_msg *)mncc);

msg = msgb_alloc(sizeof(struct gsm_mncc), "MNCC");
if (!msg)

To view, visit change 44043. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I5c7070fb383a1aa42ab45478076be444d6b211f4
Gerrit-Change-Number: 44043
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon@freecalypso.org>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>