Attention is currently required from: pespin.

View Change

1 comment:

• File src/common/gsm_data.c:

  • Patch Set #1, Line 344: lchan_meas_reset(lchan);

    imho this doesn't belong here, but inside lchan code/FSM triggered by gsm_lchan_release() above.

    `gsm_lchan_release()` returns early if `lchan->state == LCHAN_S_NONE` (not active), i.e. it's only resetting the state of active logical channels. I need the meas state to be reset for inactive channels too.

    I think we can move this `lchan_meas_reset()` call before the `lchan->state == LCHAN_S_NONE` check, so that the meas state is reset regardless of the state. What do you think?

To view, visit change 42909. To unsubscribe, or for help writing mail filters, visit settings.