Attention is currently required from: fixeria, lynxis lazus.
View Change
1 comment:
Patchset:
Patch Set #4:
Then please at least add unit tests here. I am aiming for good testing coverage. […]
Yes, I mentioned why:
1- I need to keep maintaining and fixing conflicts with new commits being reviewed and merged while mine keep stuck here.
2- The testsuite infra needs to be improved at the same time too.
Tbh, I sometimes have the feeling that while I try hard to push forward others patches as quickly as possible to improve their efforts, mine get trapped in here for no good reason for too much time, making it worse for everyone.
To view, visit change 37924. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4
Gerrit-Change-Number: 37924
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis@fe80.eu>
Gerrit-Comment-Date: Wed, 04 Sep 2024 13:59:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>