Attention is currently required from: pespin.

View Change

3 comments:

• File src/osmo-bsc/bts_nokia_site.c:

  • Patch Set #3, Line 604: { 2, "reserved" },

    Maybe start it with a cap letter too? Or is this specified as so somewhere?

    you mean the "reserved" one? All the rest starts with cap letter.

  • Patch Set #3, Line 1716: if (find_element(noh->data, len_data, NOKIA_EI_RESET_TYPE, &reset_type,

    afaiu this IE is unrelated to the EI_BTS_TYPE above, so it probably makes much more sense to pul lal […]

    Acknowledged

  • Patch Set #3, Line 1718: LOG_BTS(bts, DNM, LOGL_INFO, "Rx BTS reset type = %s\n",

    You probably want to do '%s' (with simple quotes) since the strings have spaces, to easiely understa […]

    Acknowledged

To view, visit change 39315. To unsubscribe, or for help writing mail filters, visit settings.