Attention is currently required from: Hoernchen, laforge.

View Change

8 comments:

• File utils/Makefile.am:

  • Patch Set #10, Line 2: ..

    You wouldn't need these relative paths if you used `$(top_srcdir)`.

  • Patch Set #10, Line 2: AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES) -I${srcdir}/../Transceiver52M/arch/common -I${srcdir}/../Transceiver52M/device/common -I${srcdir}/../Transceiver52M

    Also, for the sake of readability, one item per line please.

  • Patch Set #10, Line 3: lpthread

    This is actually not a compiler flag, so `LDADD` is a better fit.
    If it's needed only for the new binary you're adding, then please add it to `burst_gen_LDADD`.

  • Patch Set #10, Line 4: LIBOSMOCODING_CFLAGS

    Is libosmocoding also needed by your new tool? If not, move it to `osmo_prbs_tool_CFLAGS`.

  • Patch Set #10, Line 13: burst-gen

    Add `osmo-` prefix for consistency with `osmo-prbs-tool`?

  • Patch Set #10, Line 15: burst_gen_SOURCES = va-test/burst-gen.cpp ${srcdir}/../Transceiver52M/grgsm_vitac/grgsm_vitac.cpp ${srcdir}/../Transceiver52M/grgsm_vitac/viterbi_detector.cc

    Same here, one file per line please.

  • Patch Set #10, Line 17: ../Transceiver52M/libtransceiver_common.la \

    tabs vs spaces

• File utils/va-test/burst-gen.cpp:

  • Patch Set #10, Line 524: int main()

    doesn't compiler warn about missing `return (int)`?

To view, visit change 33945. To unsubscribe, or for help writing mail filters, visit settings.