Attention is currently required from: laforge, pespin.
12 comments:
File include/osmocom/core/tun.h:
Patch Set #9, Line 29: const char *osmo_tundev_get_name(const struct osmo_tundev *tundev);
maybe add a new line below this? given that the two functions below are about dev_name, and there's another line break before netns_name
File src/core/tun.c:
Patch Set #4, Line 238: LOGTUN(tundev, LOGL_ERROR, "Cannot obtain netns file descriptor: %s (%d)\n",
log netns_name here?
(not relevant anymore in current patchset)
Patch Set #4, Line 245: if (tundev->netns_name) {
same condition, why is this not part of the above if-block?
Done
Patch Set #4, Line 405: whien
when
Done
File src/core/tun.c:
Add "Prepare netns: " for consistency with other messages in this function?
use a global talloc ctx and pass that here?
Patch Set #9, Line 233: inreface
interface
Patch Set #9, Line 284: tundev_mnl_link_state_change
Maybe call it "tundev_mnl_link_on_state_change" (adding _on_)?
I just read through it and was confused that there was no api call to libmnl to actually change the state before realizing that this gets called by the function below after it was changed, not to change it.
is this intentionally the same as in the if (up) case? if so, why have it in both the if and else branches?
Patch Set #9, Line 375: /* RTM_NEWLINK doesn't work either */
leftover comment?
Patch Set #9, Line 448: status
why status and not len?
open
To view, visit change 31025. To unsubscribe, or for help writing mail filters, visit settings.