Attention is currently required from: keith, pespin.

View Change

2 comments:

• File src/libmsc/db.c:

  • Patch Set #4, Line 302: id = $id LIMIT 1

    I consider it standard practice to add a LIMIT 1 to a query that is only intended to ever delete max […]

    Not sure if this really a standard practice, given that not all database bacnends support the `LIMIT` statement in `DELETE FROM` queries. I am not strictly against this as it does not hurt, but it looks redundant to me. The uniqueness of `id` (primary key) must be guaranteed by the database engine, so either you have exactly one record matching your query or none.

  • Patch Set #4, Line 303: DB_STMT_SMS_DEL_EXPIRED

    I believe this was already brought up here by other reviewers: we now have two identical queries in the array. One of them should be removed to avoid duplication (can be done in a separate patch).

To view, visit change 28340. To unsubscribe, or for help writing mail filters, visit settings.