Attention is currently required from: jolly, laforge, pespin.

jolly uploaded patch set #6 to this change.

View Change

The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder

After writing VTY config, run sync() in a different thread

Running sync() after writing VTY config causes the process to stop for
a fraction of a second. This may result in delayed processing that
causes buffer underruns, overflows and delay. This is a problem with
applications that do real-time signal processing such as osmo-trx and
osmo-bts.

After some discussions, I decided to simply remove the sync() commands
from the VTY's write function. There is still a backup file created
of the previously saved configuration before writing the current
configurtion. Loosing current configuration caused by a system crash
afterwards is very unlikely with modern file systems.

Related: OS#6438
Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44
---
M src/vty/command.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/98/37798/6

To view, visit change 37798. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44
Gerrit-Change-Number: 37798
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: Hoernchen <ewild@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>