Attention is currently required from: osmith.
View Change
1 comment:
File src/hlr_vty.c:
Patch Set #1, Line 300: vty_out(vty, " no subscriber-create-on-demand%s", VTY_NEWLINE);
This is the default, I thought we omit these. […]
Well, I believe printing a setting explicitly is better than omitting values.
I expected to get some questions here, let's see what others think.
To view, visit change 37779. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ib553172655f83dad1ac0e0254615c8c207d79ca9
Gerrit-Change-Number: 37779
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Aug 2024 12:35:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith@sysmocom.de>