Attention is currently required from: pespin.

View Change

2 comments:

• File src/libosmo-mgcp-client/mgcp_client.c:

  • Patch Set #5, Line 1254: pt = map_codec_to_pt(mgcp_msg->ptmap, mgcp_msg->ptmap_len, mgcp_msg->codecs[i]);

    shouldn't this line be moved inside each case? […]

    its probably better, yes.

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #5, Line 704: if (target_fmt_present && target_fmt == MGCP_GSM_HR_FMT_TS101318)

    This looks wrong. If it's the target, then the comment with the " =>" is wrong.

    Its correct, but a bit confusing though. I have added some comments to make it clearer.

    The function should convert every input into the opposite format. Unless the format is specified. So wehen we detect that the input is TS101813 and the target format is also TS101813, then we abort. If nothing is specified we go ahead and do the conversion blindly. If the target format is specified and it is RFC5993, which is the opposite then we also go ahead and do the conversion.

To view, visit change 31214. To unsubscribe, or for help writing mail filters, visit settings.