Attention is currently required from: osmith, neels, laforge.
8 comments:
Commit Message:
Patch Set #4, Line 9: * Drop hardcoded features for osmo-bts and nanobts
Be careful here, nanobts may support some features it doesn't report, since there may be feature enums which we added ourselves? So it's possibel that for nanobts we may need some? Or we can simply check bts_is_nanobts() or alike?
File include/osmocom/bsc/bts.h:
Patch Set #4, Line 302: /* BTS reports features on start up. When false, BTS model features get
"on start up" -> "during OML bring up".
Patch Set #4, Line 303: * copied to BTS features. */
"features during object initialization".
Actually, for the case of nanobts we may use both things: set up some during _init(), and some during OML bring up.
Patch Set #4, Line 347: bool features_set;
I'd rather call it "features_present" or "feature_available" or "features_known", features_set may drive to cofusion, like it's a set of features.
File src/osmo-bsc/bts.c:
Patch Set #4, Line 507: if (bts->features_set) {
Let's move bts global checks before the trx/ts specific checks in the llist_for_each_entry above.
Patch Set #4, Line 630: memset(bts->_features_data, 0, sizeof(bts->_features_data));
You still may want to copy them in case of nanobts.
File src/osmo-bsc/bts_ipaccess_nanobts.c:
Patch Set #4, Line 498: bts_model_nanobts.features_get_reported = true;
I'm pretty sure this can be set when defining bts_model_nanobts directly in global scope, not here.
File src/osmo-bsc/bts_osmobts.c:
Patch Set #4, Line 204: model_osmobts.features_get_reported = true;
same, can be set in bts_model_nanobts directly.
To view, visit change 27923. To unsubscribe, or for help writing mail filters, visit settings.