Attention is currently required from: fixeria.
View Change
1 comment:
Commit Message:
Patch Set #2, Line 7: Split
Why? Are you planning to use it somewhere else?
It just follows the usual object structure where you have an _alloc() and a _free()/_destroy() function.
Makes it a lot easier to find out stuff.
Also, it allows separating the lookup from the allocation, which really has nothing to do.
To view, visit change 38663. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I38f9f19bb43d29999c4a7ba1a537403d1d58e880
Gerrit-Change-Number: 38663
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Nov 2024 19:48:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>