osmith has uploaded this change for review.

View Change

ipaccess: update_fd_settings: use LOGL_ERROR

Use LOGL_ERROR if setsockopt fails, so errors are less likely to go
unnoticed.

Related: OS#5786
Change-Id: I519a88dce30c01d2ea02cf900b1892497b494e09
---
M src/input/ipaccess.c
1 file changed, 5 insertions(+), 5 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/82/30282/1

diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index 3a20967..bde2c12 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -605,7 +605,7 @@
 		val = 1;
 		ret = setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, &val, sizeof(val));
 		if (ret < 0)
-			LOGP(DLINP, LOGL_NOTICE, "Failed to set keepalive: %s\n",
+			LOGP(DLINP, LOGL_ERROR, "Failed to set keepalive: %s\n",
 			     strerror(errno));
 		else
 			LOGP(DLINP, LOGL_NOTICE, "Keepalive is set: %i\n", ret);
@@ -617,7 +617,7 @@
 		ret = setsockopt(fd, IPPROTO_TCP, TCP_KEEPIDLE,
 				 &val, sizeof(val));
 		if (ret < 0)
-			LOGP(DLINP, LOGL_NOTICE,
+			LOGP(DLINP, LOGL_ERROR,
 			     "Failed to set keepalive idle time: %s\n",
 			     strerror(errno));
 		val = line->keepalive_probe_interval > -1 ?
@@ -626,7 +626,7 @@
 		ret = setsockopt(fd, IPPROTO_TCP, TCP_KEEPINTVL,
 				 &val, sizeof(val));
 		if (ret < 0)
-			LOGP(DLINP, LOGL_NOTICE,
+			LOGP(DLINP, LOGL_ERROR,
 			     "Failed to set keepalive interval: %s\n",
 			     strerror(errno));
 		val = line->keepalive_num_probes > 0 ?
@@ -635,7 +635,7 @@
 		ret = setsockopt(fd, IPPROTO_TCP, TCP_KEEPCNT,
 				 &val, sizeof(val));
 		if (ret < 0)
-			LOGP(DLINP, LOGL_NOTICE,
+			LOGP(DLINP, LOGL_ERROR,
 			     "Failed to set keepalive count: %s\n",
 			     strerror(errno));
                 val = 1000 * line->keepalive_num_probes *
@@ -644,7 +644,7 @@
                 ret = setsockopt(fd, IPPROTO_TCP, TCP_USER_TIMEOUT,
                                  &val, sizeof(val));
                 if (ret < 0)
-                        LOGP(DLINP, LOGL_NOTICE,
+			LOGP(DLINP, LOGL_ERROR,
                              "Failed to set user timoeut: %s\n",
                              strerror(errno));
 	}

To view, visit change 30282. To unsubscribe, or for help writing mail filters, visit settings.