Attention is currently required from: arehbein, laforge.

View Change

1 comment:

• File src/core/gsmtap_util.c:

  • Patch Set #5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL);

    This will leak iofds returned by osmo_iofd_setup().

    Also having a read_cb() will cause (de-)allocations for each message, which will impact performance. Maybe the sink should stay a struct osmo_fd? The alternative would be to simply never read from that fd and just keep it open there so no ICMP errors are sent.

To view, visit change 34743. To unsubscribe, or for help writing mail filters, visit settings.