Attention is currently required from: fixeria, laforge, osmith.

View Change

4 comments:

• File ggsn/ggsn.h:

  • Patch Set #4, Line 36: #define IPV6_HDR_MAX_SIZE 40 /* Assume no extension headers in general... */

    IPV6_HDR_MAX_SIZE < IPV4_HDR_MAX_SIZE, is this correct?

    Yes because we assume no extension headers used by ipv6, while we account for maximum number of extension headers for ipv4.

• File ggsn/ggsn_vty.c:

  • Patch Set #4, Line 425: "mtu (<0-1464>|default)",

    maybe use MAX_POSSIBLE_APN_MTU instead of 1464 here?

    It cannot be done, I already tried once. The preprocessor puts there the expression, not the result, hence not a number.

  • Patch Set #4, Line 428: "Default value of the MTU of the APN (1420)")

    maybe use MAX_DESIRED_APN_MTU instead of 1420 here?

    It cannot be done, I already tried once. The preprocessor puts there the expression, not the result, hence not a number.

  • Patch Set #4, Line 708: vty_out(vty, " mtu %" PRIu16 "%s", apn->cfg.mtu, VTY_NEWLINE);

    skip if == default?

    I'd rather keep it like this, I think it's actually a good idea to always print it, the default is not obvious at all and may need some tweaking sometimes...

To view, visit change 38457. To unsubscribe, or for help writing mail filters, visit settings.