Attention is currently required from: neels, pespin, lynxis lazus.
12 comments:
File include/osmocom/bsc/bts_setup_ramp.h:
Patch Set #3, Line 31: BTS_SETUP_RAMP_INIT, /** initial state */
Thank you!
I don't want to be bothersome here, but now it's not a valid doxygen comment style either...
File include/osmocom/bsc/gsm_data.h:
Patch Set #3, Line 959: struct {
It probably makes more sense to have this struct declared in the bts_ramp_setup. […]
Done
File src/osmo-bsc/bsc_vty.c:
Patch Set #4, Line 1326: BTS_NR_STR
BTS_NR_STR should not be here anymore.
Patch Set #4, Line 3088: cfg_bsc_bts_setup_ramping_cmd,
What's wrong with spacing here? It was good before.
Patch Set #4, Line 3100: bts-setup-ramping-step-interval
IMO, 'bts-setup-ramping' and 'step-interval' should be separate things, so in the VTY one could list all parameters quickly:
bts-setup-ramping ?
step-interval <0-65535> [help string]
step-size <0-65535> [help string]
Patch Set #4, Line 3103: CMD_ATTR_IMMEDIATE)
Spacing again.
Patch Set #4, Line 3112: cfg_bsc_bts_setup_ramping_step_size_cmd,
Again spacing/alignment problems.
Patch Set #4, Line 3115: Set a step interval
Step size or step interval? Copy pasted.
File src/osmo-bsc/bts_setup_ramp.c:
Patch Set #4, Line 98: && net->bts_setup_ramp.step_size > 0
Extra spacing makes this construct hard to read. Please align properly.
Patch Set #4, Line 101: net->bts_setup_ramp.active
Use bts_setup_ramp_active()?
Patch Set #4, Line 107: net->bts_setup_ramp.active
Use !bts_setup_ramp_active()?
Patch Set #4, Line 164: net->bts_setup_ramp.active
Why not using the API bts_setup_ramp_active() for that?
To view, visit change 29788. To unsubscribe, or for help writing mail filters, visit settings.