Attention is currently required from: fixeria, laforge, pespin.

falconia uploaded patch set #4 to this change.

View Change

The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+2 by fixeria, Verified+1 by Jenkins Builder

The change is no longer submittable: Code-Review and Verified are unsatisfied now.

mgw: add "X-Side: CN" / "X-Side: RAN" to emitted CRCX

For every call leg handled by OsmoMSC, 2 CRCX commands get sent to
the MSC-associated MGW: one for CN side and one for RAN side. Using
newly added support in libosmo-mgcp-client, add non-standard X-Side
extension parameter to mark which side is which - if enabled via
'mgw indicate-side' setting in vty.

This indication of RAN vs CN side in CRCX becomes mandatory when
OsmoMSC is used with Themyscira Wireless transcoder MGW instead of
OsmoMGW (next patch in the series), but even when regular OsmoMGW
is used, the non-standard X-Side extension parameter is harmless
(ignored by OsmoMGW) while aiding debugging via packet capture,
making it clearly visible in pcap which CRCX and which resulting
ConnectionId corresponds to which side of the MSC.

Depends: I713147d6567fb30de09b2272478d717093d6170e (osmo-mgw.git)
Change-Id: Ie26ece9035ee579f2af84a13d71a553f98817592
---
M TODO-RELEASE
M include/osmocom/msc/gsm_data.h
M include/osmocom/msc/rtp_stream.h
M src/libmsc/call_leg.c
M src/libmsc/msc_vty.c
M src/libmsc/rtp_stream.c
M tests/test_nodes.vty
7 files changed, 54 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/01/44001/4

To view, visit change 44001. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie26ece9035ee579f2af84a13d71a553f98817592
Gerrit-Change-Number: 44001
Gerrit-PatchSet: 4
Gerrit-Owner: falconia <falcon@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>