tnt has uploaded this change for review.

View Change

icE1usb fw/gpsdo: Never use invalid measurements to feed loop

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
Change-Id: I9c7b81c6e2e600ed49ac766fa33df23747dd339e
---
M firmware/ice40-riscv/icE1usb/gpsdo.c
1 file changed, 4 insertions(+), 3 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/92/27892/1

diff --git a/firmware/ice40-riscv/icE1usb/gpsdo.c b/firmware/ice40-riscv/icE1usb/gpsdo.c
index cd9866c..7e3682f 100644
--- a/firmware/ice40-riscv/icE1usb/gpsdo.c
+++ b/firmware/ice40-riscv/icE1usb/gpsdo.c
@@ -286,10 +286,11 @@
 	} else {
 		/* Count invalid measurements and if too many of
 		 * them, we go back to hold-over */
-		if (++g_gpsdo.meas.invalid >= MAX_INVALID) {
+		if (++g_gpsdo.meas.invalid >= MAX_INVALID)
 			g_gpsdo.state = STATE_HOLD_OVER;
-			return;
-		}
+
+		/* In all cases, invalid measurements are not used */
+		return;
 	}
 
 	g_gpsdo.meas.invalid = 0;

To view, visit change 27892. To unsubscribe, or for help writing mail filters, visit settings.