Attention is currently required from: fixeria, laforge, pespin.

this must first and foremost be fixed in upstream asn1c, if it hasn't yet, as libasn1c is merely a shared library version of the asn1c runtime.

Confirmed already fixed upstream, so nothing new is needed there. Current vlm/asn1c master carries the corrected '&&' guard in CHOICE_outmost_tag (skeletons/constr_CHOICE.c:471):

    if(present > 0 && present <= td->elements_count) {

The || -> && correctness fix landed upstream back in 2017: commit 494fb707a7cbfc8c563c7125efcf801142e0d0ea ("fix warnings", Lev Walkin, 2017-08-07) changed the guard from '||' to '&&', and the follow-up 63a35237b1704f1491f6a8c40dca6a02b3781e96 (2017-08-10) dropped the redundant '(unsigned)' cast, giving the form master ships today.

libasn1c 0.9.38 is a stale snapshot of the asn1c runtime skeletons that predates that fix, so this change simply backports the already-upstreamed guard into our vendored copy. No upstream asn1c patch is warranted -- upstream is already correct.

(Also amended in patchset 4 to add the missing space after 'if' so gerrit-lint/checkpatch is happy; the '&&' correctness fix is unchanged.)

View Change

To view, visit change 42890. To unsubscribe, or for help writing mail filters, visit settings.