Attention is currently required from: pespin, dexter.
View Change
2 comments:
File src/gsm/lapdm.c:
Patch Set #5, Line 730: if (LAPDm_ADDR_SHORT_L2(msg->l2h[2]) == 0x0) {
cosmetic: Here you write 0x0, but there is also LAPDm_CTRL_U_BITS(msg->l2h[3]) == 0), which just us […]
Done
Patch Set #5, Line 735: if (le->mode == LAPDM_MODE_MS
you forgot to move "else if" in the same line.
Done
To view, visit change 32934. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If04115884743455c7bf2b2bc5f7e49e74b6ffb60
Gerrit-Change-Number: 32934
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Thu, 25 May 2023 10:28:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: dexter <pmaier@sysmocom.de>
Gerrit-MessageType: comment