Attention is currently required from: dexter.

View Change

4 comments:

• File pySim/esim/saip/personalization.py:

  • Patch Set #11, Line 209: def get_values_from_pes(cls, pes: ProfileElementSequence) -> Generator:

    As far as I understand ''' just marks a multiline comment, but shouldn't this be a doctstring?

    if you mean the triple single quotes -- AFAIK *any* string format in this location is a docstring. Though laforge has indicated that i sould follow the triple double quote convention.

  • Patch Set #11, Line 290: def decimal_hex_to_str(cls, val):

    also have not seen single quotes as comment chars before...

    Done

  • Patch Set #11, Line 292: if isinstance(val, bytes):

    Is it always ensured that we won't get sometimes bytes and sometimes bytearrays?

    the values are coming from a ProfileElementSequence's decoded section, should always be either a hexstr or bytes. ok?

  • Patch Set #11, Line 297: val = unrpad(val, c)

    You are sure that you want to turn val to ascii, like "4141" => "AA"? (am a bit confused since the m […]

    I got this code from elsewhere (or reversing code from elsewhere?)
    and I am positively sure that it works as intended.

    this is how PIN and PUK are stored, apparently actually the ascii codes of the PIN/PUK digits. The function makes a PIN/PUK human readable.

    The only reason to not directly do a .decode('ascii') is apparently the rpad / unrpad.

To view, visit change 40198. To unsubscribe, or for help writing mail filters, visit settings.