View Change

1 comment:

• File src/core/select.c:

  • Patch Set #1, Line 223: if (fd->fd >= 0)

    Here I'd like to have an OSMO_ASSERT(fd->fd >=0) instead, but that made one unit test in osmo-mgw hi […]

    BTW, the fact that we assert there would also probably mean we can optimize osmo_fd_is_registered() to be O(k) instead of O(n), because we can guarantee that the pointer in the table won't leak and will be NULL when the fd is unregistered.

To view, visit change 31808. To unsubscribe, or for help writing mail filters, visit settings.