fixeria submitted this change.

View Change


Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified
BTS_Tests: also test TCH/EFS (EFR) in TC_speech_no_rtp_tchf

Also add TODO comments for TCH/AFS and TCH/AHS.

Change-Id: I272b4343f895889f6cb3e0d3aba2c63b4eab08a2
Related: SYS#5919, OS#4823
---
M bts/BTS_Tests.ttcn
1 file changed, 23 insertions(+), 0 deletions(-)

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 2989cb8..2a56a25 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -8292,6 +8292,14 @@
vc_conn := f_start_handler(refers(f_TC_speech_no_rtp), pars);
vc_conn.done;

+ /* TS1, TCH/F, V2 (EFR codec) */
+ pars := valueof(t_Pars(ts_RslChanNr_Bm(1), ts_RSL_ChanMode(RSL_CHRT_TCH_F, RSL_CMOD_SP_GSM2)));
+ vc_conn := f_start_handler(refers(f_TC_speech_no_rtp), pars);
+ vc_conn.done;
+
+ /* TODO: we don't know what's the expected behavior for TCH/AFS, so we don't test it here.
+ * Current osmo-bts is sending FACCH/F with dummy LAPDm func=UI frames. */
+
Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
testcase TC_speech_no_rtp_tchh() runs on test_CT {
@@ -8305,6 +8313,9 @@
vc_conn := f_start_handler(refers(f_TC_speech_no_rtp), pars);
vc_conn.done;

+ /* TODO: we don't know what's the expected behavior for TCH/AHS, so we don't test it here.
+ * Current osmo-bts is sending FACCH/H with dummy LAPDm func=UI frames (whenever possible). */
+
Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}


To view, visit change 33725. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I272b4343f895889f6cb3e0d3aba2c63b4eab08a2
Gerrit-Change-Number: 33725
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged