Attention is currently required from: osmith, pespin.
Patch set 4:Code-Review +1
View Change
2 comments:
Commit Message:
File src/osmux_input.c:
Patch Set #3, Line 454: 1-
ok nvm
Agreeing with Oliver here. I haven't seen this style used anywhere so far. Moreover, the '-' in actively used in Russian spelling (in some cases you can even replace a verb with '-'). Not critical, but weird.
To view, visit change 30197. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9596501adf5b7b91983618c92c7b1792ee9461a3
Gerrit-Change-Number: 30197
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Sun, 20 Nov 2022 21:53:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment