Attention is currently required from: osmith, pespin.

View Change

1 comment:

• File gen_makefile.py:

  • Patch Set #1, Line 375:

    for i in {build_proj}/default/bin/*; do \\
          if [ -e "$$i" ]; then \\
            install -v -Dm755 "$$i" -t {shlex.quote(args.install_prefix)}/bin/; \\
    

    Does this really pick the right if-branch in the case of osmo-s1gw?

    ```
    $ make release
    ...
    $ ls -la _build/default/bin/
    total 104
    drwxr-xr-x 2 fixeria fixeria 4096 июл 29 20:14 .
    drwxr-xr-x 6 fixeria fixeria 4096 июл 29 20:17 ..
    -rwxr-xr-x 1 fixeria fixeria 95317 июл 29 20:14 setup_gen
    ```

    IIUC, this code will just copy `setup_gen` and not execute `make install`?

    Maybe be something like this instead?

    ```
    if grep -q "^install:" Makefile; then
      # make install as you do in the else branch
    else
      for i in {build_proj}/default/bin/*; do
        install -v -Dm755 "$$i" -t {shlex.quote(args.install_prefix)}/bin/; \\
      fi
    fi
    ```

    Feels like I am missing something.

To view, visit change 40770. To unsubscribe, or for help writing mail filters, visit settings.