Attention is currently required from: neels, laforge, fixeria.

View Change

2 comments:

• File src/osmo-bsc/bts.c:

  • Patch Set #6, Line 502: if (!bts_gprs_mode_is_compat(bts, bts->gprs.mode)) {

    && instead of nested if?

    Done on purpose here, so we have a if (bts->features_known) { ... } block where we can have multiple checks in the future. If it's strongly preferred to use && here however, I'd change it.

• File src/osmo-bsc/bts_osmobts.c:

  • Patch Set #6, Line 208: /* Adjust bts_init/bts_model_init in OsmoBTS to report new features.

    i wonder what this comment attempts to say, sounds like legacy that we can drop?

    I just added this comment recently. What I meant with it is: when OsmoBTS supports a new feature, OsmoBTS code should be adjusted to report this feature. Instead of just adding the feature here to the BTS model, as it had been done sometimes in the past.

To view, visit change 27923. To unsubscribe, or for help writing mail filters, visit settings.