Attention is currently required from: osmith, laforge, pespin.

View Change

1 comment:

• File src/host/layer23/src/modem/grr.c:

  • Patch Set #3, Line 278: if ((dm_or_tbf & (1 << 1)) == 0) {

    it is not clear by looking at this conditon + comment whether the if condition is UL TBF or DL TBF

    The comment clearly states "Uplink TBF", so the if-condition is obviously checking if it's an Uplink TBF assignment. The 2nd LSB bit (indicating DL TBF) is expected to be unset.

To view, visit change 33414. To unsubscribe, or for help writing mail filters, visit settings.