pespin submitted this change.

View Change

Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve
nokia: Fix uninitialized access

/osmo-bsc/src/osmo-bsc/bts_nokia_site.c:1903:36: error: 'bcch_trx_nr' may be used uninitialized [-Werror=maybe-uninitialized]
1903 | if (trx->nr != bcch_trx_nr) {
|

Change-Id: I6bfdefb44235291a5a1f1c72e5a5149d15e19b8f
---
M src/osmo-bsc/bts_nokia_site.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c
index 4e3f63c..e5f2c9d 100644
--- a/src/osmo-bsc/bts_nokia_site.c
+++ b/src/osmo-bsc/bts_nokia_site.c
@@ -1884,7 +1884,7 @@
abis_nm_ack(bts, ref);
if (bts->nokia.configured != 0) {
struct gsm_bts_trx *trx;
- uint8_t bcch_trx_nr;
+ int bcch_trx_nr = -1;
/* we first need to unlock and reset the TRX that runs BCCH */
llist_for_each_entry(trx, &bts->trx_list, list) {
if (trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH ||

To view, visit change 39701. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6bfdefb44235291a5a1f1c72e5a5149d15e19b8f
Gerrit-Change-Number: 39701
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: csaba.sipos <metro4@freemail.hu>
Gerrit-Reviewer: domi <domi@tomcsanyi.net>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>