Attention is currently required from: laforge, osmith.
Patch set 2:Code-Review +1
View Change
4 comments:
File src/gtp-genl.c:
Patch Set #2, Line 60: }
default: assert()
Patch Set #2, Line 69: }
default: assert()
Patch Set #2, Line 239: switch (pdp.ms_addr.family) {
All this can simply be:
inet_ntop(pdp.ms_addr.family, &pdp.ms_addr.ip4, buf, sizeof(buf));
Patch Set #2, Line 249: switch (pdp.sgsn_addr.family) {
inet_ntop(pdp.sgsn_addr.family, &pdp.sgsn_addr.ip4, buf, sizeof(buf));
To view, visit change 34735. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: If864c9170f74af52a95cbc4cdb1b866e0309306b
Gerrit-Change-Number: 34735
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Thu, 19 Oct 2023 14:30:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment