laforge submitted this change.

View Change

Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve
sccp_scoc: Match local conn by src_ref, not dest_ref

SCRC Routing Failure is dispatched when a local SCCP Connection Oriented
message fails to be routed to a peer.
Hence, in order to figure out if the msg belons to a local conn, we need
to use the src_ref (the sender), not the dst_ref (the peer's id).

As a result, event SCOC_E_RCOC_ROUT_FAIL_IND was potentially being set
to the wrong connection FSM.

Change-Id: I0090f4088de407b476cfb0a6d652b384af714306
---
M src/sccp_scoc.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c
index c977110..a725a02 100644
--- a/src/sccp_scoc.c
+++ b/src/sccp_scoc.c
@@ -1608,7 +1608,7 @@
xua_hdr_dump(xua, &xua_dialect_sua));

/* try to dispatch to connection FSM (if any) */
- conn_id = xua_msg_get_u32(xua, SUA_IEI_DEST_REF);
+ conn_id = xua_msg_get_u32(xua, SUA_IEI_SRC_REF);
conn = conn_find_by_id(inst, conn_id);
if (conn) {
osmo_fsm_inst_dispatch(conn->fi,

To view, visit change 40302. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I0090f4088de407b476cfb0a6d652b384af714306
Gerrit-Change-Number: 40302
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>