Attention is currently required from: jolly.

Patch set 2:Code-Review +1

View Change

4 comments:

• File README.md:

  • Patch Set #2, Line 4: element in the 3GPP IoT eSIM system as described in SGP.31 and SGP.32. It interfaces between the eUICC on one side,

    oops! There is a trailing white space that was already there before...

  • Patch Set #2, Line 95: * `add-initial-eim <PATH>` specifies the path to an initial eIM configuration file.

    I would move this line to the bottom since we usually pass the operations at the end of the command-line. And it looks more consistent.

  • Patch Set #2, Line 104: During the first run, onomondo-ipa will create an `nvstate.bin` file in its working directory.

    again A whitsepace that has been overlooked. We should remove it with this patch.

  • Patch Set #2, Line 121: the eidValue from the eUICC and use it to query the eIM for eIM packages. In case no eIM package is available (error

    I would change

    "it will read the eUICC configuration"

    To

    "it will read the eIM configuration data"

To view, visit change 43403. To unsubscribe, or for help writing mail filters, visit settings.