Attention is currently required from: jolly.
3 comments:
Commit Message:
Patch Set #5, Line 9: Deprecated functions gsm48_generate_mid_from_*() are replaced by
yay! \o/
Patchset:
Just to make sure, did you test a bit this? This kind of patches can easily add regressions. laforge already submitted a similar once a few weeks/months ago and I think it is still in gerrit because I spotted some possible regressions.
File src/host/layer23/src/mobile/gsm48_mm.c:
Patch Set #5, Line 276: int gsm48_encode_mi(struct osmocom_ms *ms, struct msgb *msg, bool tlv, uint8_t mi_type, bool emergency_imsi)
Did you think about having 2 functions gsm48_encode_mi_tlv() and gsm48_encode_mi_lv()?
Then have:
gsm48_encode_mi_tlv(..) {
msgb_put_u8(msg, GSM48_IE_MOBILE_ID);
return gsm48_encode_mi_lv(...)
}
To view, visit change 34484. To unsubscribe, or for help writing mail filters, visit settings.